Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e2c9cab

Browse filesBrowse files
committed
build: do not set -mminimal-toc with clang
This is a gcc-only option, do not pass to clang. PR-URL: #59484 Refs: nodejs/build#4091 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
1 parent c5d68c4 commit e2c9cab
Copy full SHA for e2c9cab

File tree

Expand file treeCollapse file tree

1 file changed

+12
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+12
-2
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+12-2Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -542,7 +542,12 @@
542542
'ldflags': [ '-m32' ],
543543
}],
544544
[ 'host_arch=="ppc64" and OS not in "aix os400"', {
545-
'cflags': [ '-m64', '-mminimal-toc' ],
545+
'conditions': [
546+
[ 'clang==0', {
547+
'cflags': [ '-mminimal-toc' ],
548+
}],
549+
],
550+
'cflags': [ '-m64' ],
546551
'ldflags': [ '-m64' ],
547552
}],
548553
[ 'host_arch=="s390x" and OS=="linux"', {
@@ -566,7 +571,12 @@
566571
'ldflags': [ '-m32' ],
567572
}],
568573
[ 'target_arch=="ppc64" and OS not in "aix os400"', {
569-
'cflags': [ '-m64', '-mminimal-toc' ],
574+
'conditions': [
575+
[ 'clang==0', {
576+
'cflags': [ '-mminimal-toc' ],
577+
}],
578+
],
579+
'cflags': [ '-m64' ],
570580
'ldflags': [ '-m64' ],
571581
}],
572582
[ 'target_arch=="s390x" and OS=="linux"', {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.