Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8f9c642

Browse filesBrowse files
zcbenzmarco-ippolito
authored andcommitted
build: fix GN build for cares/uv deps
PR-URL: #55477 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent ac583d4 commit 8f9c642
Copy full SHA for 8f9c642

File tree

Expand file treeCollapse file tree

3 files changed

+6
-4
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+6
-4
lines changed

‎deps/cares/unofficial.gni

Copy file name to clipboardExpand all lines: deps/cares/unofficial.gni
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,10 @@ template("cares_gn_build") {
3838
]
3939
}
4040

41-
include_dirs = [ "src/lib" ]
41+
include_dirs = [
42+
"src/lib",
43+
"src/lib/include",
44+
]
4245
if (is_win) {
4346
include_dirs += [ "config/win32" ]
4447
} else if (is_linux) {
@@ -55,9 +58,6 @@ template("cares_gn_build") {
5558
}
5659

5760
sources = gypi_values.cares_sources_common
58-
if (is_win) {
59-
sources += gypi_values.cares_sources_win
60-
}
6161
if (is_linux) {
6262
sources += [ "config/linux/ares_config.h" ]
6363
}

‎deps/uv/unofficial.gni

Copy file name to clipboardExpand all lines: deps/uv/unofficial.gni
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ template("uv_gn_build") {
4040
"-Wno-extra-semi",
4141
"-Wno-implicit-fallthrough",
4242
"-Wno-missing-braces",
43+
"-Wno-sign-compare",
4344
"-Wno-string-conversion",
4445
"-Wno-shadow",
4546
"-Wno-unreachable-code",

‎unofficial.gni

Copy file name to clipboardExpand all lines: unofficial.gni
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ template("node_gn_build") {
6868
"-Wno-extra-semi",
6969
"-Wno-implicit-fallthrough",
7070
"-Wno-macro-redefined",
71+
"-Wno-missing-braces",
7172
"-Wno-return-type",
7273
"-Wno-shadow",
7374
"-Wno-sometimes-uninitialized",

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.