Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 47a7564

Browse filesBrowse files
legendecasaduh95
legendecas
authored and
aduh95
committed
doc: classify Chrome DevTools Protocol as tier 2
Chrome DevTools Protocol is the de-facto debugger protocol for Node.js and is tested regularly in Node.js test suite / CI. It matches the tier 2 classification but lacks proper documentation in Node.js. Classify the Chrome DevTools Protocol as tier 2 with a target of tier 1 once we have proper documentation on stable protocols. On the other hand, the Chrome DevTools Frontend is not shipped with Node.js and not tested in Node.js CI. So keep it as tier 3. PR-URL: #57634 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
1 parent 6d01286 commit 47a7564
Copy full SHA for 47a7564

File tree

Expand file treeCollapse file tree

1 file changed

+7
-7
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+7
-7
lines changed

‎doc/contributing/diagnostic-tooling-support-tiers.md

Copy file name to clipboardExpand all lines: doc/contributing/diagnostic-tooling-support-tiers.md
+7-7Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@ The tools are currently assigned to Tiers as follows:
100100

101101
## Tier 2
102102

103-
| Tool Type | Tool/API Name | Regular Testing in Node.js CI | Integrated with Node.js | Target Tier |
104-
| --------- | ------------- | ----------------------------- | ----------------------- | ----------- |
105-
| | | | | |
103+
| Tool Type | Tool/API Name | Regular Testing in Node.js CI | Integrated with Node.js | Target Tier |
104+
| --------- | ---------------------------- | ----------------------------- | ----------------------- | ----------- |
105+
| Debugger | [Chrome DevTools Protocol][] | Yes | Yes | 1 |
106106

107107
## Tier 3
108108

@@ -114,7 +114,7 @@ The tools are currently assigned to Tiers as follows:
114114
| Profiling | V8 --interpreted-frames-native-stack | Yes | Yes | 2 |
115115
| Profiling | [Linux perf][] | Yes | Partial | 2 |
116116
| Profiling | [node-clinic][] | No | No | 3 |
117-
| Debugger | [Chrome Dev tools][] | No | No | 3 |
117+
| Debugger | [Chrome DevTools Frontend][] | No | No | 3 |
118118

119119
## Tier 4
120120

@@ -129,15 +129,15 @@ The tools are currently assigned to Tiers as follows:
129129
| Memory | V8 heap profiler | No | Yes | 1 |
130130
| Memory | V8 sampling heap profiler | No | Yes | 1 |
131131
| AsyncFlow | [Async Hooks (API)][] | ? | Yes | 1 |
132-
| Debugger | V8 Debug protocol (API) | No | Yes | 1 |
133132
| Debugger | [Command line Debug Client][] | ? | Yes | 1 |
134133
| Tracing | [trace\_events (API)][trace_events (API)] | No | Yes | 1 |
135134
| Tracing | trace\_gc | No | Yes | 1 |
136135

137136
[0x]: https://github.com/davidmarkclements/0x
138137
[Async Hooks (API)]: https://nodejs.org/api/async_hooks.html
139-
[Chrome Dev Tools]: https://developer.chrome.com/docs/devtools/
140-
[Command line Debug Client]: https://nodejs.org/api/inspector.html
138+
[Chrome DevTools Frontend]: https://developer.chrome.com/docs/devtools/
139+
[Chrome DevTools Protocol]: https://chromedevtools.github.io/devtools-protocol/
140+
[Command line Debug Client]: https://nodejs.org/api/debugger.html
141141
[Linux perf]: https://perf.wiki.kernel.org/index.php/Main_Page
142142
[diagnostic report]: https://nodejs.org/api/report.html
143143
[node-clinic]: https://github.com/clinicjs/node-clinic/

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.