Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3a3220a

Browse filesBrowse files
ri7116aduh95
authored andcommitted
dgram: restore buffer optimization in fixBufferList
Restore the Buffer.isBuffer() check to avoid unnecessary Buffer.from() calls when the input is already a Buffer. This improves performance by 30-50% for buffer-heavy UDP operations. Includes benchmark test for fixBufferList function to verify the performance improvements across different data types and chunk sizes. PR-URL: #59934 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
1 parent 5bf21a4 commit 3a3220a
Copy full SHA for 3a3220a

File tree

Expand file treeCollapse file tree

2 files changed

+54
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+54
-0
lines changed
Open diff view settings
Collapse file

‎benchmark/dgram/send-types.js‎

Copy file name to clipboard
+52Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
'use strict';
2+
3+
const common = require('../common.js');
4+
const dgram = require('dgram');
5+
const { Buffer } = require('buffer');
6+
7+
const bench = common.createBenchmark(main, {
8+
type: ['string', 'buffer', 'mixed', 'typedarray'],
9+
chunks: [1, 4, 8, 16],
10+
len: [64, 512, 1024],
11+
n: [1000],
12+
});
13+
14+
function main({ type, chunks, len, n }) {
15+
const socket = dgram.createSocket('udp4');
16+
17+
let testData;
18+
switch (type) {
19+
case 'string':
20+
testData = Array(chunks).fill('a'.repeat(len));
21+
break;
22+
case 'buffer':
23+
testData = Array(chunks).fill(Buffer.alloc(len, 'a'));
24+
break;
25+
case 'mixed':
26+
testData = [];
27+
for (let i = 0; i < chunks; i++) {
28+
if (i % 2 === 0) {
29+
testData.push(Buffer.alloc(len, 'a'));
30+
} else {
31+
testData.push('a'.repeat(len));
32+
}
33+
}
34+
break;
35+
case 'typedarray':
36+
testData = Array(chunks).fill(new Uint8Array(len).fill(97));
37+
break;
38+
}
39+
40+
bench.start();
41+
42+
for (let i = 0; i < n; i++) {
43+
socket.send(testData, 12345, 'localhost', (err) => {
44+
if (err && err.code !== 'ENOTCONN' && err.code !== 'ECONNREFUSED') {
45+
throw err;
46+
}
47+
});
48+
}
49+
50+
bench.end(n);
51+
socket.close();
52+
}
Collapse file

‎lib/dgram.js‎

Copy file name to clipboardExpand all lines: lib/dgram.js
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -548,6 +548,8 @@ function fixBufferList(list) {
548548
const buf = list[i];
549549
if (typeof buf === 'string')
550550
newlist[i] = Buffer.from(buf);
551+
else if (Buffer.isBuffer(buf))
552+
newlist[i] = buf;
551553
else if (!isArrayBufferView(buf))
552554
return null;
553555
else

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.