Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 129a1d6

Browse filesBrowse files
targosrichardlau
targos
authored and
richardlau
committed
build: fix getting OpenSSL version on Windows
Node.js on Windows is built with `clang`, not `gcc`. PR-URL: #59609 Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 92100a8 commit 129a1d6
Copy full SHA for 129a1d6

File tree

Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
original_argv = sys.argv[1:]
2121

2222
# gcc and g++ as defaults matches what GYP's Makefile generator does,
23-
# except on OS X.
24-
CC = os.environ.get('CC', 'cc' if sys.platform == 'darwin' else 'gcc')
25-
CXX = os.environ.get('CXX', 'c++' if sys.platform == 'darwin' else 'g++')
23+
# except on macOS and Windows.
24+
CC = os.environ.get('CC', 'cc' if sys.platform == 'darwin' else 'clang' if sys.platform == 'win32' else 'gcc')
25+
CXX = os.environ.get('CXX', 'c++' if sys.platform == 'darwin' else 'clang' if sys.platform == 'win32' else 'g++')
2626

2727
tools_path = Path('tools')
2828

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.