Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1289ef8

Browse filesBrowse files
addaleaxaduh95
authored andcommitted
src: remove unnecessary shadowed functions on Utf8Value & BufferValue
Both of these are already implemented on the superclass. PR-URL: #60056 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent d1fb8a5 commit 1289ef8
Copy full SHA for 1289ef8

File tree

Expand file treeCollapse file tree

1 file changed

+0
-9
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-9
lines changed
Open diff view settings
Collapse file

‎src/util.h‎

Copy file name to clipboardExpand all lines: src/util.h
-9Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -552,11 +552,6 @@ class Utf8Value : public MaybeStackBuffer<char> {
552552
public:
553553
explicit Utf8Value(v8::Isolate* isolate, v8::Local<v8::Value> value);
554554

555-
inline std::string ToString() const { return std::string(out(), length()); }
556-
inline std::string_view ToStringView() const {
557-
return std::string_view(out(), length());
558-
}
559-
560555
inline bool operator==(const char* a) const { return strcmp(out(), a) == 0; }
561556
inline bool operator!=(const char* a) const { return !(*this == a); }
562557
};
@@ -570,10 +565,6 @@ class BufferValue : public MaybeStackBuffer<char> {
570565
public:
571566
explicit BufferValue(v8::Isolate* isolate, v8::Local<v8::Value> value);
572567

573-
inline std::string ToString() const { return std::string(out(), length()); }
574-
inline std::string_view ToStringView() const {
575-
return std::string_view(out(), length());
576-
}
577568
inline std::u8string_view ToU8StringView() const {
578569
return std::u8string_view(reinterpret_cast<const char8_t*>(out()),
579570
length());

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.