Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 020c939

Browse filesBrowse files
aduh95marco-ippolito
authored andcommitted
doc: allow request for TSC reviews via the GitHub UI
PR-URL: #56493 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 500f3cc commit 020c939
Copy full SHA for 020c939

File tree

Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed

‎doc/contributing/collaborator-guide.md

Copy file name to clipboardExpand all lines: doc/contributing/collaborator-guide.md
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,6 @@ deprecation level of an API.
523523
Collaborators can opt to elevate pull requests or issues to the [TSC][].
524524
Do this if a pull request or issue:
525525

526-
* Is labeled `semver-major`, or
527526
* Has a significant impact on the codebase, or
528527
* Is controversial, or
529528
* Is at an impasse among collaborators who are participating in the discussion.
@@ -532,6 +531,9 @@ Do this if a pull request or issue:
532531
[TSC][]. Do not use the GitHub UI on the right-hand side to assign to
533532
`@nodejs/tsc` or request a review from `@nodejs/tsc`.
534533

534+
If a pull request is labeled `semver-major`, you can request a review from the
535+
`@nodejs/tsc` GitHub team.
536+
535537
The TSC serves as the final arbiter where required.
536538

537539
## Landing pull requests

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.