-
Notifications
You must be signed in to change notification settings - Fork 71
fix(deps): update dependency log-process-errors to v11 #6443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request adds or modifies JavaScript ( |
99af4b5
to
f9a6268
Compare
This pull request adds or modifies JavaScript ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// Do not use log-process-errors prettification with errors thrown by `utils.build.*` | ||
const errorA = isBuildError(originalError) ? originalError : error | ||
|
||
await handleError(errorA) | ||
await handleError(error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine and not worth reimplementing, but just calling out that this is a behavioural change. Previously errors were (except for isBuildError() === true
errors) pretty-printed, but now they never are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unfortunate, but the library no longer exposes the "unprettified" error so I decided to cut my losses with this one
This pull request adds or modifies JavaScript ( |
Summary
The breaking changes were in the v10 release (https://github.com/ehmicky/log-process-errors/releases/tag/10.0.0)
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)