Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(deps): update dependency log-process-errors to v11 #6443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented Jun 9, 2025

Summary

The breaking changes were in the v10 release (https://github.com/ehmicky/log-process-errors/releases/tag/10.0.0)


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Copy link
Contributor

github-actions bot commented Jun 9, 2025

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork force-pushed the upgrade-log-process-errors branch from 99af4b5 to f9a6268 Compare June 10, 2025 17:11
@mrstork mrstork changed the title Upgrade log process errors fix(deps): update dependency log-process-errors to v11 Jun 10, 2025
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork marked this pull request as ready for review June 10, 2025 17:27
@mrstork mrstork requested a review from a team as a code owner June 10, 2025 17:27
Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// Do not use log-process-errors prettification with errors thrown by `utils.build.*`
const errorA = isBuildError(originalError) ? originalError : error

await handleError(errorA)
await handleError(error)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine and not worth reimplementing, but just calling out that this is a behavioural change. Previously errors were (except for isBuildError() === true errors) pretty-printed, but now they never are.

Copy link
Contributor Author

@mrstork mrstork Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate, but the library no longer exposes the "unprettified" error so I decided to cut my losses with this one

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork enabled auto-merge (squash) June 10, 2025 18:44
@mrstork mrstork merged commit ab8f6e8 into main Jun 10, 2025
59 of 61 checks passed
@mrstork mrstork deleted the upgrade-log-process-errors branch June 10, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.