Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[11.x] Test Improvements #53586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024
Merged

[11.x] Test Improvements #53586

merged 2 commits into from
Nov 20, 2024

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Nov 20, 2024

Correctly test Queue using phpredis and predis. InteractsWithRedis configure redis as set it to $this->redis but the TestCase are using Redis connection set via created Application (using Testbench).

Correctly test Queue using `phpredis` and `predis`

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone marked this pull request as ready for review November 20, 2024 03:01
@taylorotwell taylorotwell merged commit 7187a93 into 11.x Nov 20, 2024
33 checks passed
@taylorotwell taylorotwell deleted the test-improvements-redis branch November 20, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.