jupyter_config_dir - reorder home_dir initialization#251
Merged
blink1073 merged 1 commit intojupyter:masterjupyter/jupyter_core:masterfrom Feb 15, 2022
dharmaquark:0222-config-dirdharmaquark/jupyter_core:0222-config-dirCopy head branch name to clipboard
Merged
jupyter_config_dir - reorder home_dir initialization#251blink1073 merged 1 commit intojupyter:masterjupyter/jupyter_core:masterfrom dharmaquark:0222-config-dirdharmaquark/jupyter_core:0222-config-dirCopy head branch name to clipboard
blink1073 merged 1 commit intojupyter:masterjupyter/jupyter_core:masterfrom
dharmaquark:0222-config-dirdharmaquark/jupyter_core:0222-config-dirCopy head branch name to clipboard
Conversation
blink1073
approved these changes
Feb 15, 2022
Contributor
blink1073
left a comment
There was a problem hiding this comment.
LGTM, thanks @dharmaquark!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the initialization of the home_dir variable, so that this logic will not get hit if
JUPYTER_CONFIG_DIRorJUPYTER_NO_CONFIGare set in the environment (this helps to avoid any OS level issues accessing or resolving default file paths when the config directory path is already being set explicitly as an environment variable)