Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: Prevent panic in try_reserve/try_with_capacity on capacity overflow #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seanmonstar merged 1 commit into from
Oct 27, 2025
Merged

fix: Prevent panic in try_reserve/try_with_capacity on capacity overflow #787

seanmonstar merged 1 commit into from
Oct 27, 2025
+5 −10

Conversation

@AriajSarkar
Copy link
Contributor

@AriajSarkar AriajSarkar commented Oct 27, 2025

Summary

Fixes #785

Prevents panic in try_reserve() and try_with_capacity() when capacity calculations overflow. This fixes the API contract violation where try_* methods were panicking instead of returning Result.

Problem

The internal helper function to_raw_capacity() panics on arithmetic overflow:

fn to_raw_capacity(n: usize) -> usize {
    match n.checked_add(n / 3) {
        Some(n) => n,
        None => panic!("requested capacity {} too large...", n),
    }
}

seanmonstar
seanmonstar approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar seanmonstar merged commit 691af72 into hyperium:master Oct 27, 2025
10 checks passed
@AriajSarkar AriajSarkar mentioned this pull request Nov 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

try_reserve can panic despite "try" prefix suggesting error handling

2 participants

@AriajSarkar @seanmonstar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.