🐛 Fix support for StreamingResponses with dependencies with yield or UploadFiles, close after the response is done
#14099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endencies with yield
…d, as those caused memory issues before
…rated background tasks
…from dependencies AsyncExitStack
Contributor
|
📝 Docs preview for commit 9087a2a at: https://3154752a.fastapitiangolo.pages.dev Modified Pages |
Contributor
|
📝 Docs preview for commit 343d3a2 at: https://01ef1bba.fastapitiangolo.pages.dev Modified Pages |
Contributor
|
📝 Docs preview for commit 7acdb2c at: https://ac42d2b2.fastapitiangolo.pages.dev Modified Pages |
This was referenced Sep 21, 2025
yield, close after the response is doneStreamingResponses with dependencies with yield or UploadFiles, close after the response is done
Contributor
|
📝 Docs preview for commit e999745 at: https://b0ab811e.fastapitiangolo.pages.dev Modified Pages |
Contributor
|
📝 Docs preview for commit b338294 at: https://07fe17cb.fastapitiangolo.pages.dev Modified Pages |
nilslindemann
added a commit
to nilslindemann/fastapi
that referenced
this pull request
Oct 1, 2025
YuriiMotov
added a commit
that referenced
this pull request
Oct 1, 2025
|
This PR also fixes #12508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Fix support for
StreamingResponses with dependencies withyieldorUploadFiles, close after the response is doneThere's (again) an
AsyncExitStackmiddleware, now used mainly to close objects after the response is done.There's also a new wrapper duplicating some logic in Starlette but creating an
AsyncExitStackfor the exit code in dependencies withyield, for regular responses and WebSockets as well.The exit code of dependencies with
yieldis now executed after the response is done.