Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Investigate errors on missing $CONDA on macos-13 #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Conversation

@jaimergp jaimergp requested a review from a team as a code owner April 23, 2024 11:15
@jaimergp
Copy link
Member Author

Yoohoo, reproduces now! We were not considering that GH-hosted x64 runners on macOS could happen. But that's the problem with macos-13. It's x64 and doesn't bundle any $CONDA.

I'll submit a potential fix now.

@jaimergp jaimergp changed the title Investigate errors on missing $CONDA Investigate errors on missing $CONDA on macos-13 Apr 23, 2024
@@ -15,7 +16,8 @@ export const bundledMinicondaUser: types.IInstallerProvider = {
inputs.miniforgeVariant === "" &&
inputs.miniforgeVersion === "" &&
inputs.architecture === "x64" &&
inputs.installerUrl === ""
inputs.installerUrl === "" &&
MINICONDA_DIR_PATH.length > 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That list of &&s is getting a bit unwieldy 😆 !

Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! fix looks nice and simple :)

Merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.