add NaiveDate::abs_diff#1752
Merged
djc merged 2 commits intochronotope:mainchronotope/chrono:mainfrom Oct 14, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1752 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 39 39
Lines 16254 16262 +8
=======================================
+ Hits 14775 14783 +8
Misses 1479 1479 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Only on |
Contributor
Author
|
I couldn't come up with a name that I'd really like. "days_since" implies that one date is greater, "days_between" implies an open interval and would be a source of many off-by-one errors. |
djc
approved these changes
Oct 14, 2025
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
NaiveDate::abs_diff, a method for calculating the distance between twoNaiveDates expressed in days.The other option is to implement this onNaiveDateonly, so that there are no surprises around the time component being ignored for this purpose.Closes #1746