Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[MCOMPILER-582] Automatic detection of release option for JDK < 9 #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2024
Merged

[MCOMPILER-582] Automatic detection of release option for JDK < 9 #228

merged 1 commit into from
Mar 13, 2024

Conversation

slawekjaranowski
Copy link
Member

@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Mar 12, 2024
kwin
kwin requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@kwin kwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the commit message/JIRA title it is not really clear what is changed. Maybe we can rename to Disregard release option for JDK < 9 so that this appears prominently in the release notes.
The commit message should focus on adding the IT and changing the documentation.

src/site/apt/examples/set-compiler-release.apt.vm Outdated Show resolved Hide resolved
@slawekjaranowski
Copy link
Member Author

What do you think about commit subject and jira title - like:
Automatic detection of release option for JDK < 9

of course commit message will contain description what is added.

My purpose of this change is to show new feature in release notes.

@slawekjaranowski slawekjaranowski requested a review from kwin March 13, 2024 19:19
kwin
kwin reviewed Mar 13, 2024
View reviewed changes
src/site/apt/examples/set-compiler-release.apt.vm Outdated Show resolved Hide resolved
kwin
kwin reviewed Mar 13, 2024
View reviewed changes
src/site/apt/examples/set-compiler-release.apt.vm Outdated Show resolved Hide resolved
kwin
kwin reviewed Mar 13, 2024
View reviewed changes
src/site/apt/examples/set-compiler-release.apt.vm Outdated Show resolved Hide resolved
kwin
kwin reviewed Mar 13, 2024
View reviewed changes
src/site/apt/examples/set-compiler-release.apt.vm Outdated Show resolved Hide resolved
@slawekjaranowski @kwin
[MCOMPILER-582] Automatic detection of release option for JDK < 9
e26e483 
- add ITs for confirm feature
- extends documentation

Co-authored-by: Konrad Windszus <kwin@apache.org>
@slawekjaranowski slawekjaranowski changed the title [MCOMPILER-582] Release option without profile for JDK 8 [MCOMPILER-582] Automatic detection of release option for JDK < 9 Mar 13, 2024
@slawekjaranowski
Copy link
Member Author

@kwin - ok, I prepare a final commit - please look if was squashed ok

@slawekjaranowski slawekjaranowski merged commit ceacf68 into master Mar 13, 2024
@slawekjaranowski slawekjaranowski deleted the MCOMPILER-582 branch March 13, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwin kwin kwin approved these changes

@gnodet gnodet Awaiting requested review from gnodet

@slachiewicz slachiewicz Awaiting requested review from slachiewicz

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slawekjaranowski @kwin
Morty Proxy This is a proxified and sanitized view of the page, visit original site.