Add security warning to TrustStrategy implementations documentation #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
reviewed
Oct 2, 2023
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/TrustAllStrategy.java
Outdated
Show resolved
Hide resolved
|
@Marcono1234 I also propose |
Should I include this in this PR or create a separate one? Also, should these changes be backported to 4.x; and in that case should I do that or do you want to do this afterwards? |
|
@Marcono1234 Just deprecate |
|
Have pushed the changes, I hope that is what you had in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to improve the documentation of
TrustAllStrategyandTrustSelfSignedStrategyby mentioning their security implications and suggesting more secure alternatives.For
TrustSelfSignedStrategyit also documents what exactly the strategy does. Otherwise without looking at the implementation details users might erroneously think it is always necessary to useTrustSelfSignedStrategywhen using self-signed certificates (even if they are also in the truststore), which is not the case.Any feedback is appreciated!