Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(forms): interop supports CVAs with signals #64618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeanMeche wants to merge 1 commit into from
Closed

fix(forms): interop supports CVAs with signals #64618

JeanMeche wants to merge 1 commit into from

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Oct 23, 2025

The directive implemnetation might set CVA values during the template evaluation. Since the template is a reactive context we need to untrack when setting the CVA values to prevent writing to signals in a reactive context.

fixes #64614

@ngbot ngbot bot added this to the Backlog milestone Oct 23, 2025
@JeanMeche JeanMeche requested a review from leonsenft October 23, 2025 11:16
@JeanMeche JeanMeche force-pushed the fix/signal-cva branch 2 times, most recently from 3168748 to 9c2da93 Compare October 23, 2025 12:49
@JeanMeche
fix(forms): interop supports CVAs with signals
4e18cf3 
The directive implemnetation might set CVA values during the template evaluation. Since the template is a reactive context we need to untrack when setting the CVA values to prevent writing to signals in a reactive context.

fixes angular#64614
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels Oct 23, 2025
@crisbeto
Copy link
Member

crisbeto commented Oct 24, 2025

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto pushed a commit that referenced this pull request Oct 24, 2025
@JeanMeche @crisbeto
fix(forms): interop supports CVAs with signals (#64618)
a1ac9a6 
The directive implemnetation might set CVA values during the template evaluation. Since the template is a reactive context we need to untrack when setting the CVA values to prevent writing to signals in a reactive context.

fixes #64614

PR Close #64618
@crisbeto crisbeto closed this in 15d4bd5 Oct 24, 2025
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 24, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leonsenft leonsenft leonsenft approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: forms target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Signal forms: CVA interop fails if CVA uses signals

3 participants

@JeanMeche @crisbeto @leonsenft
Morty Proxy This is a proxified and sanitized view of the page, visit original site.