fix(router): Respect custom UrlSerializer handling of query parameters
#64449
+163
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f36ff9 to
6e5e777
Compare
Previously, query parameters passed to `router.createUrlTree` were simply converted to strings. This meant that any custom serialization logic in a custom `UrlSerializer` was not applied. This could lead to inconsistencies between navigations triggered from the URL bar (which are parsed by the serializer) and navigations triggered programmatically. This change ensures that query parameters are normalized using the provided `UrlSerializer`. The values are serialized and then parsed to ensure they are in the same format as if they had come from a URL. This allows custom serializers to handle complex objects in query parameters consistently. Fixes angular#47307
6e5e777 to
5a94154
Compare
Contributor
Author
|
Targeting major and marking risky despite the green TGP. |
thePunderWoman
approved these changes
Oct 17, 2025
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
LGTM
reviewed-for: fw-general, public-api
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
thePunderWoman
added a commit
to thePunderWoman/angular
that referenced
this pull request
Oct 18, 2025
… parameters (angular#64449)" This reverts commit 46ae034.
thePunderWoman
added a commit
that referenced
this pull request
Oct 18, 2025
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, query parameters passed to
router.createUrlTreewere simply converted to strings. This meant that any custom serialization logic in a customUrlSerializerwas not applied. This could lead to inconsistencies between navigations triggered from the URL bar (which are parsed by the serializer) and navigations triggered programmatically.This change ensures that query parameters are normalized using the provided
UrlSerializer. The values are serialized and then parsed to ensure they are in the same format as if they had come from a URL. This allows custom serializers to handle complex objects in query parameters consistently.Fixes #47307