fix(router): Fix memory leak through Navigation.abort and canDeactiva… #64141
+14
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5b0e71 to
dc10b6b
Compare
JeanMeche
approved these changes
Sep 30, 2025
Member
|
(The change doens't merge cleanly into the patch branch, we'll need a separate PR) |
Member
|
Looks like there are consistent failures |
dc10b6b to
3e63b64
Compare
Contributor
Author
Fixed. |
…te guards This commit updates the internal transition to handle context retention through the abort function. This retention chain included the previousNavigation and setting this to a noop function resolves the issue. fixes angular#63983
3e63b64 to
d6696f2
Compare
Member
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
napulitanfrontend
pushed a commit
to napulitanfrontend/angular
that referenced
this pull request
Oct 10, 2025
…te guards (angular#64141) This commit updates the internal transition to handle context retention through the abort function. This retention chain included the previousNavigation and setting this to a noop function resolves the issue. fixes angular#63983 PR Close angular#64141
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…te guards
This commit updates the internal transition to handle context retention through the abort function. This retention chain included the previousNavigation and setting this to a noop function resolves the issue.
fixes #63983