-
Notifications
You must be signed in to change notification settings - Fork 27k
refactor(core): remove moduleId from Component metadata
#63482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bf0c03b to
758cf77
Compare
moduleId from Component metadat.moduleId from Component metadata
It was deprecated by angular#49496 as it had no effect. BREAKING CHANGE: `moduleId` was removed from `Component` metadata.
758cf77 to
4e42c51
Compare
mmalerba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
thePunderWoman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: fw-general, public-api
|
This PR was merged into the repository. The changes were merged into the following branches:
|
) It was deprecated by angular#49496 as it had no effect. BREAKING CHANGE: `moduleId` was removed from `Component` metadata. PR Close angular#63482
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
It was deprecated by #49496 as it had no effect.
BREAKING CHANGE:
moduleIdwas removed fromComponentmetadata.