Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Aug 29, 2025

It was deprecated by #49496 as it had no effect.

BREAKING CHANGE: moduleId was removed from Component metadata.

@JeanMeche
Copy link
Member Author

Passing TGP

@JeanMeche JeanMeche marked this pull request as ready for review September 9, 2025 22:23
@JeanMeche JeanMeche changed the title refactor(core): remove moduleId from Component metadat. refactor(core): remove moduleId from Component metadata Sep 9, 2025
@JeanMeche JeanMeche added the target: major This PR is targeted for the next major release label Sep 9, 2025
It was deprecated by angular#49496 as it had no effect.

BREAKING CHANGE: `moduleId` was removed from `Component` metadata.
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Sep 9, 2025
@JeanMeche JeanMeche added breaking changes and removed detected: breaking change PR contains a commit with a breaking change labels Sep 9, 2025
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from atscott September 12, 2025 05:50
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-general, public-api

@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label Sep 15, 2025
@thePunderWoman thePunderWoman added the detected: breaking change PR contains a commit with a breaking change label Sep 15, 2025
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

wildcardalice pushed a commit to wildcardalice/angular that referenced this pull request Sep 18, 2025
)

It was deprecated by angular#49496 as it had no effect.

BREAKING CHANGE: `moduleId` was removed from `Component` metadata.

PR Close angular#63482
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime breaking changes detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.