-
Notifications
You must be signed in to change notification settings - Fork 27k
feat(router): convert lastSuccessfulNavigation to signal
#63057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3046187 to
30373f0
Compare
|
The patch CL to submit alongside this PR: https://critique.corp.google.com/cl/793706017 |
atscott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
This commit also include an `ng update` migration to ensure `lastSuccessfulNavigation` is invoked. BREAKING CHANGE: `lastSuccessfulNavigation` is now a signal and needs to be invoked
30373f0 to
9117590
Compare
crisbeto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
|
This PR was merged into the repository by commit 4e0fc81. The changes were merged into the following branches: main |
|
@JeanMeche I noticed a change in the behavior of On a direct page visit (the initial navigation), the Is this new behavior intentional and an expected part of the new signal-based API? I couldn't find info of this specific behavior in the PR, so I wanted to confirm. Thank you for the clarification. |
|
@IgorSedov Do you have a reproduction? There were no changes to the timing of the updates in this CL |
|
@atscott My bad. Thanks for the quick response. I found the problem on my end. I tested in different configurations (SSR, Zoneless, v20/v21) and everything is fine. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit also include an
ng updatemigration to ensurelastSuccessfulNavigationis invoked.BREAKING CHANGE:
lastSuccessfulNavigationis now a signal and needs to be invoked