fix(elements): return value on signal input getter #62113
Closed
+50
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2eecaf1 to
d216d18
Compare
JoostK
reviewed
Jun 18, 2025
c63c5ac to
06676ee
Compare
JoostK
reviewed
Jun 18, 2025
06676ee to
39957d5
Compare
39957d5 to
c83214b
Compare
Member
|
Converting to draft, as we'll look at it again when we enter the v21 breaking change window. |
BREAKING CHANGE: Fix signal input getter behavior in custom elements. Before this change, signal inputs in custom elements required function calls to access their values (`elementRef.newInput()`), while decorator inputs were accessed directly (`elementRef.oldInput`). This inconsistency caused confusion and typing difficulties. The getter behavior has been standardized so signal inputs can now be accessed directly, matching the behavior of decorator inputs: Before: - Decorator Input: `elementRef.oldInput` - Signal Input: `elementRef.newInput()` After: - Decorator Input: `elementRef.oldInput` - Signal Input: `elementRef.newInput` closes angular#62097
c83214b to
1972f9c
Compare
Member
JeanMeche
approved these changes
Oct 1, 2025
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
napulitanfrontend
pushed a commit
to napulitanfrontend/angular
that referenced
this pull request
Oct 10, 2025
BREAKING CHANGE: Fix signal input getter behavior in custom elements. Before this change, signal inputs in custom elements required function calls to access their values (`elementRef.newInput()`), while decorator inputs were accessed directly (`elementRef.oldInput`). This inconsistency caused confusion and typing difficulties. The getter behavior has been standardized so signal inputs can now be accessed directly, matching the behavior of decorator inputs: Before: - Decorator Input: `elementRef.oldInput` - Signal Input: `elementRef.newInput()` After: - Decorator Input: `elementRef.oldInput` - Signal Input: `elementRef.newInput` closes angular#62097 PR Close angular#62113
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #62097
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #62097
What is the new behavior?
Does this PR introduce a breaking change?
Other information