fix(core): async EventEmitter error should not prevent stability #61028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
reviewed
Apr 28, 2025
atscott
approved these changes
Apr 28, 2025
8f81fb4 to
edd01de
Compare
Contributor
|
@arturovt The new test is failing on CI |
Contributor
Author
|
Ah this test passes in the browser, but throws that error in |
This commit wraps the `fn` invocation with `try-finally`, ensuring that the pending task (added in [this commit](angular@d5c6ee4)) is always removed. Prior to this commit, if a subscriber threw an error, it would prevent the application from becoming stable — though this shouldn't happen under normal scenarios because the error should be handled by the RxJS error handler or Angular's error handler. Errors should not silently prevent the application from being rendered on the server.
edd01de to
67fad9a
Compare
kirjs
approved these changes
Apr 29, 2025
Contributor
|
This PR was merged into the repository by commit 8d82a39. The changes were merged into the following branches: main, 19.2.x |
mmalerba
pushed a commit
that referenced
this pull request
Apr 30, 2025
) This commit wraps the `fn` invocation with `try-finally`, ensuring that the pending task (added in [this commit](d5c6ee4)) is always removed. Prior to this commit, if a subscriber threw an error, it would prevent the application from becoming stable — though this shouldn't happen under normal scenarios because the error should be handled by the RxJS error handler or Angular's error handler. Errors should not silently prevent the application from being rendered on the server. PR Close #61028
thePunderWoman
added a commit
to thePunderWoman/angular
that referenced
this pull request
Apr 30, 2025
…ity (angular#61028)" This reverts commit 8d82a39.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit wraps the
fninvocation withtry-finally, ensuring that the pending task (added in this commit) is always removed.Prior to this commit, if a subscriber threw an error, it would prevent the application from becoming stable — though this shouldn't happen under normal scenarios because the error should be handled by the RxJS error handler or Angular's error handler.
Errors should not silently prevent the application from being rendered on the server.