Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(compiler): throw for invalid "as" expression in if block #60580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crisbeto wants to merge 1 commit into from
Closed

fix(compiler): throw for invalid "as" expression in if block #60580

crisbeto wants to merge 1 commit into from

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 27, 2025

Adds some validation that the "as" expression in an @if block is valid.

Fixes #59939.

@crisbeto
fix(compiler): throw for invalid "as" expression in if block
2fe8226 
Adds some validation that the "as" expression in an `@if` block is valid.

Fixes angular#59939.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 27, 2025
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 27, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 27, 2025
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 27, 2025
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Mar 27, 2025

This PR was merged into the repository by commit e6d2afb.

The changes were merged into the following branches: main, 19.2.x

thePunderWoman pushed a commit that referenced this pull request Mar 27, 2025
@crisbeto @thePunderWoman
fix(compiler): throw for invalid "as" expression in if block (#60580)
ca5aa4d 
Adds some validation that the "as" expression in an `@if` block is valid.

Fixes #59939.

PR Close #60580
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 27, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

statement in @if behind as not marked as error by compiler

3 participants

@crisbeto @thePunderWoman @pkozlowski-opensource
Morty Proxy This is a proxified and sanitized view of the page, visit original site.