-
Notifications
You must be signed in to change notification settings - Fork 26.9k
fix(core): fix used templates are not deleted #60459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @JeanMeche,
Thanks |
packages/core/schematics/ng-generate/control-flow-migration/util.ts
Outdated
Show resolved
Hide resolved
thePunderWoman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
After running the control flow migration, used templates are not deleted.
559fae8 to
d9491fa
Compare
|
This PR was merged into the repository by commit cf5c61c. The changes were merged into the following branches: main, 19.2.x |
After running the control flow migration, used templates are not deleted. PR Close #60459
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
After running the control flow migration, used templates are not deleted.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
After running the control flow migration, used templates are not deleted. I also replaced the implementation of template search from regex via AST
Issue Number: #56965
What is the new behavior?
Expected result would be that the used template is removed.
Does this PR introduce a breaking change?