fix(core): catch hydration marker with implicit body tag #60429
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08b9dd4 to
5b23cf6
Compare
Contributor
Author
|
Adding some tests because there's a few more edge cases I should handle here. |
Contributor
Author
|
Alright, this should be ready for some eyes. Now handles both the optional |
AndrewKushnir
approved these changes
Mar 18, 2025
When the browser parses a valid html5 response like this: ```html <!-- ... --> <title>My page</title> </head> <!--nghm--> <app-root></app-root> <!-- ... --> ``` The resulting DOM will only start adding nodes to the body when it runs into the first non-header tag. E.g.: ```yml - head - title "My page" - comment "nghm" - body - app-root ``` This isn't a sign that comments are modified, so it seems worth to handle it gracefully.
Member
|
This PR was merged into the repository by commit b461e06. The changes were merged into the following branches: main, 19.2.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Mar 19, 2025
When the browser parses a valid html5 response like this: ```html <!-- ... --> <title>My page</title> </head> <!--nghm--> <app-root></app-root> <!-- ... --> ``` The resulting DOM will only start adding nodes to the body when it runs into the first non-header tag. E.g.: ```yml - head - title "My page" - comment "nghm" - body - app-root ``` This isn't a sign that comments are modified, so it seems worth to handle it gracefully. PR Close #60429
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the browser parses a valid html5 response like this:
The resulting DOM will only start adding nodes to the body when it runs into the first non-header tag. E.g.:
This isn't a sign that comments are modified, so it seems worth to handle it gracefully.
Motivation here is to allow some more minification of the HTML response and easier integration with systems that compose response fragments from different sources.