-
Notifications
You must be signed in to change notification settings - Fork 27k
feat(http): Provide http services in root #56212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
97725c3 to
cf03dae
Compare
|
does this means, we have httpclient included by default, even if we dont add provideHttpClient()? if yes, should we guard against adding provider function ? |
I may be missing something obvious here but if we do guard and I think we should one way or another then we'd need another way of configuring certain HttpClient features like interceptor functions. We could expose their tokens as public API ( This may be a contrived example but providers are made to be flexible and I strongly believe they should remain that way. |
|
This a technical demo, of what 0-config setup for the Http stack. The subject hasn't been accepted nor discussed with the team yet. The idea here to is say, hey we could have use the default setting without any providers but if you need some customization, you can still use Also, the topic of exposing the interceptors token, has already been discussed in #51303. The token being is by design, as interceptors should be set in a single place so the executed in a predictable order. |
fd8ba24 to
0be918c
Compare
thePunderWoman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
43819bb to
99f99a0
Compare
2afec95 to
b8ceb35
Compare
92e8e5a to
8497301
Compare
c754b81 to
6f11f20
Compare
9300a76 to
a9158e1
Compare
The changes introduced in this commit allows to use the HttpClient without the provider function.
a9158e1 to
0690576
Compare
|
G3 has been cleaned up & Passing TGP |
atscott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
|
This PR was merged into the repository by commit 4bed062. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The changes introduced in this commit allows to use the HttpClient without the provider function.
Bundle size impact <1kB, mostly due to creating the providers and factories for the services providedin root.