fix(core): cleanup signal consumers for all views#53351
Closed
JoostK wants to merge 1 commit intoangular:mainangular/angular:mainfrom
JoostK:signals/destroy-all-viewsJoostK/angular:signals/destroy-all-viewsCopy head branch name to clipboard
Closed
fix(core): cleanup signal consumers for all views#53351JoostK wants to merge 1 commit intoangular:mainangular/angular:mainfrom JoostK:signals/destroy-all-viewsJoostK/angular:signals/destroy-all-viewsCopy head branch name to clipboard
JoostK wants to merge 1 commit intoangular:mainangular/angular:mainfrom
JoostK:signals/destroy-all-viewsJoostK/angular:signals/destroy-all-viewsCopy head branch name to clipboard
Conversation
This commit fixes a memory leak where signal consumers would not be cleaned up for descendant views when a view is destroyed, because the cleanup logic was only invoked for the view that is itself being destroyed.
atscott
approved these changes
Dec 4, 2023
alxhub
approved these changes
Dec 4, 2023
Contributor
|
This PR was merged into the repository by commit 77939a3. |
dylhunn
pushed a commit
that referenced
this pull request
Dec 5, 2023
This commit fixes a memory leak where signal consumers would not be cleaned up for descendant views when a view is destroyed, because the cleanup logic was only invoked for the view that is itself being destroyed. PR Close #53351
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This commit fixes a memory leak where signal consumers would not be cleaned up for descendant views when a view is destroyed, because the cleanup logic was only invoked for the view that is itself being destroyed. PR Close angular#53351
rlmestre
pushed a commit
to rlmestre/angular
that referenced
this pull request
Jan 26, 2024
This commit fixes a memory leak where signal consumers would not be cleaned up for descendant views when a view is destroyed, because the cleanup logic was only invoked for the view that is itself being destroyed. PR Close angular#53351
amilamen
pushed a commit
to amilamen/angular
that referenced
this pull request
Jan 26, 2024
This commit fixes a memory leak where signal consumers would not be cleaned up for descendant views when a view is destroyed, because the cleanup logic was only invoked for the view that is itself being destroyed. PR Close angular#53351
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a memory leak where signal consumers would not be cleaned up for descendant views when a view is destroyed, because the cleanup logic was only invoked for the view that is itself being destroyed.