Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(migrations): CF Migration add support for ngIf with just a then#53297

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainangular/angular:mainfrom
jessicajaniuk:empty-containerjessicajaniuk/angular:empty-containerCopy head branch name to clipboard
Closed

fix(migrations): CF Migration add support for ngIf with just a then#53297
jessicajaniuk wants to merge 1 commit intoangular:mainangular/angular:mainfrom
jessicajaniuk:empty-containerjessicajaniuk/angular:empty-containerCopy head branch name to clipboard

Conversation

@jessicajaniuk
Copy link
Contributor

Prior to this fix, the expectation that anytime then was used, else would always be present. That is not a valid assumption.

fixes: #53287

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

Prior to this fix, the expectation that anytime then was used, else would always be present. That is not a valid assumption.

fixes: angular#53287
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Nov 30, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 30, 2023
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 30, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Dec 1, 2023

This PR was merged into the repository by commit aad5e5b.

@dylhunn dylhunn closed this in aad5e5b Dec 1, 2023
dylhunn pushed a commit that referenced this pull request Dec 1, 2023
…53297)

Prior to this fix, the expectation that anytime then was used, else would always be present. That is not a valid assumption.

fixes: #53287

PR Close #53297
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 1, 2024
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…ngular#53297)

Prior to this fix, the expectation that anytime then was used, else would always be present. That is not a valid assumption.

fixes: angular#53287

PR Close angular#53297
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
…ngular#53297)

Prior to this fix, the expectation that anytime then was used, else would always be present. That is not a valid assumption.

fixes: angular#53287

PR Close angular#53297
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
…ngular#53297)

Prior to this fix, the expectation that anytime then was used, else would always be present. That is not a valid assumption.

fixes: angular#53287

PR Close angular#53297
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control flow schematic: empty ng-container is not migrated

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.