perf(http): reduce data transfer when using HTTP caching#52347
Closed
alan-agius4 wants to merge 2 commits intoangular:mainangular/angular:mainfrom
Closed
perf(http): reduce data transfer when using HTTP caching#52347alan-agius4 wants to merge 2 commits intoangular:mainangular/angular:mainfrom
alan-agius4 wants to merge 2 commits intoangular:mainangular/angular:mainfrom
Conversation
Contributor
|
How about using tuples? |
Contributor
Author
I went with a similar approach that is used for other things like hydration. Also with tuples, it feel like it would be harder to visually read what is written in the cache. |
43563ed to
c26d496
Compare
c26d496 to
66ad393
Compare
This commit reduces the property size in the http transfer cache to reduce the page payload.
Before
```html
<script id="ng-state" type="application/json">
{
"4155228514": {
"body": "....",
"headers": {},
"status": 200,
"statusText": "OK",
"url": "http://foo.com/assets/media.json",
"responseType": "json"
},
}
</script>
```
Now
```html
<script id="ng-state" type="application/json">
{
"4155228514": {
"b": "....",
"h": {},
"s": 200,
"st": "OK",
"u": "http://foo.com/assets/media.json",
"rt": "json"
},
}
</script>
```
66ad393 to
02acbb4
Compare
Contributor
|
This PR was merged into the repository by commit c5e30f1. |
dylhunn
pushed a commit
that referenced
this pull request
Oct 24, 2023
This commit reduces the property size in the http transfer cache to reduce the page payload.
Before
```html
<script id="ng-state" type="application/json">
{
"4155228514": {
"body": "....",
"headers": {},
"status": 200,
"statusText": "OK",
"url": "http://foo.com/assets/media.json",
"responseType": "json"
},
}
</script>
```
Now
```html
<script id="ng-state" type="application/json">
{
"4155228514": {
"b": "....",
"h": {},
"s": 200,
"st": "OK",
"u": "http://foo.com/assets/media.json",
"rt": "json"
},
}
</script>
```
PR Close #52347
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This commit reduces the property size in the http transfer cache to reduce the page payload.
Before
```html
<script id="ng-state" type="application/json">
{
"4155228514": {
"body": "....",
"headers": {},
"status": 200,
"statusText": "OK",
"url": "http://foo.com/assets/media.json",
"responseType": "json"
},
}
</script>
```
Now
```html
<script id="ng-state" type="application/json">
{
"4155228514": {
"b": "....",
"h": {},
"s": 200,
"st": "OK",
"u": "http://foo.com/assets/media.json",
"rt": "json"
},
}
</script>
```
PR Close angular#52347
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reduces the property size in the http transfer cache to reduce the page payload.
Before
Now