Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix link's order of arguments #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Fix link's order of arguments #989

merged 4 commits into from
Jun 4, 2024

Conversation

delatrie
Copy link
Collaborator

@delatrie delatrie commented Jun 3, 2024

Context

link(url, type, name) now is link(url, name, type). The new order is backward-compatible with Jasmine, Jest, and Cypress. The previous one isn't.

Additional changes

  • The output folder of type declarations is changed from dist to dist/types for codeceptjs, cucumberjs, and cypress. Some parameters are moved from package.json to tsconfig.json.
  • Grammar fix: getSuitesLabels is renamed to getSuiteLabels.
  • Remove duplicated env labels from newly created test results; remove getGlobalLabels from reporter utils.
  • Remove link and label from AllureCypressTestRuntime (they aren't in use now).

Checklist

@delatrie delatrie added the type:improvement Improvement or request label Jun 3, 2024
@delatrie delatrie requested a review from epszaw June 3, 2024 16:53
@github-actions github-actions bot added theme:api Javascript API related issue theme:mocha Mocha related issue theme:jest Jest related issue theme:cucumberjs CucumberJS related issue theme:jasmine Jasmine related issue theme:playwright theme:newman theme:codeceptjs theme:vitest labels Jun 3, 2024
@delatrie delatrie marked this pull request as ready for review June 4, 2024 02:23
@baev baev merged commit 59acb5d into main Jun 4, 2024
8 checks passed
@baev baev deleted the link-api-fix branch June 4, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:api Javascript API related issue theme:codeceptjs theme:cucumberjs CucumberJS related issue theme:jasmine Jasmine related issue theme:jest Jest related issue theme:mocha Mocha related issue theme:newman theme:playwright theme:vitest type:improvement Improvement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.