Fix typescript-eslint issues #1006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.eslintrc.cjs Inconsistently quoted property (quote-props) packages/allure-codeceptjs/src/reporter.ts packages/allure-codeceptjs/test/spec/runtime/legacy/attachments.test.ts packages/allure-codeceptjs/test/spec/runtime/modern/attachments.test.ts @typescript-eslint/no-unnecessary-type-assertion
baev
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR fixes invalid tsconfig resolution by package's typescript-eslint configurations. Previously, each package's
parserOptions.projectoption (except the one ofnewman-reporter-allure) was resolved to the roottsconfig.jsonleading to typing issues when accessing a package's sub-paths (e.g.,import type { /* ... */ } from "allure-js-commons/sdk"). That was because of"moduleResolution": "node"in the root config, which doesn't support exports in package.json.The fix is to provide
parserOptions.tsconfigRootDirtogether withparserOptions.projectfor each package.Additional changes
The PR also addressed the following previously hidden linting-related issues:
Note: fixed by disabling the typed checks since we don't need them much in a config file. Another option would be to include
.eslintrc.cjsin eachtsconfig.test.json(see here).tsconfig.test.jsonin allure-js-commons..eslintrc.cjs: quote-props.packages/allure-codeceptjs/src/reporter.ts,packages/allure-codeceptjs/test/spec/runtime/legacy/attachments.test.ts, andpackages/allure-codeceptjs/test/spec/runtime/modern/attachments.test.ts: @typescript-eslint/no-unnecessary-type-assertion.