Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

misc(build): switch to yarn pnp #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Sep 23, 2023
Merged

misc(build): switch to yarn pnp #776

merged 31 commits into from
Sep 23, 2023

Conversation

baev
Copy link
Member

@baev baev commented Sep 12, 2023

Context

The build passes even if no dependency is added to the module since it will be resolved from other modules' dependencies.

The best way to fix the issue is to switch to Yarn PnP.

  1. Yarn PnP
  2. Yarn Zero Installs
  3. Add Eslint & Prettier steps to the workflow
  4. Fix Eslint

Checklist

@baev baev added the type:bug Something isn't working label Sep 12, 2023
@baev baev changed the title Disable yarn cache and add node 18 misc(build): switch to yarn pnp Sep 12, 2023
@baev baev merged commit cfe708c into master Sep 23, 2023
@baev baev deleted the fix-pw branch September 23, 2023 12:29
@baev baev mentioned this pull request Sep 23, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:api Javascript API related issue theme:build theme:codeceptjs theme:cucumberjs CucumberJS related issue theme:decorators theme:jasmine Jasmine related issue theme:jest Jest related issue theme:mocha Mocha related issue theme:newman theme:playwright theme:workflow type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.