Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(types/models): add missing create constructor signature override type #12585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2022
Merged

feat(types/models): add missing create constructor signature override type #12585

merged 3 commits into from
Oct 24, 2022

Conversation

naorpeled
Copy link
Contributor

@naorpeled naorpeled commented Oct 24, 2022 •
edited
Loading

Summary

While looking into the constructor signature overrides of the Mongoose's model create function, I've noticed that one of its overrides is missing.
This PR adds it.

@naorpeled naorpeled marked this pull request as draft October 24, 2022 13:56
@naorpeled naorpeled marked this pull request as ready for review October 24, 2022 14:00
@naorpeled naorpeled changed the title feat(types/models): add missing create constructor override type feat(types/models): add missing create constructor signature override type Oct 24, 2022
vkarpov15
vkarpov15 approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.6.8 milestone Oct 24, 2022
@vkarpov15 vkarpov15 merged commit bd034fa into Automattic:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@naorpeled @vkarpov15
Morty Proxy This is a proxified and sanitized view of the page, visit original site.