add --eh-frame-hdr arg for linking#3981
Closed
dcao wants to merge 3 commits intoziglang:masterziglang/zig:masterfrom
Closed
add --eh-frame-hdr arg for linking#3981dcao wants to merge 3 commits intoziglang:masterziglang/zig:masterfrom
dcao wants to merge 3 commits intoziglang:masterziglang/zig:masterfrom
Conversation
andrewrk
requested changes
Dec 31, 2019
Member
andrewrk
left a comment
There was a problem hiding this comment.
Thanks for the patch.
I'm OK with adding this linker flag as an option, but not unconditionally. You'll need to expose it as a CLI option, a build.zig option, integrate whether or not it is enabled into the cache system, and then finally conditionally include it on the linker line.
Contributor
Author
|
@andrewrk The changes requested have been made: there's now a new CLI option, |
Member
|
Thanks! Landed in e2e9be5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3965