reset engine rest.WithExternalListener external listener #4778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
… listener for start engine
12b03f8 to
9e9f5f4
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds support for supplying an external net.Listener to the REST engine’s start logic via a new RunOption.
- Introduce
WithExternalListeneroption inrest/server.go - Add
StartHttpWithListnerhelper inrest/internal/starter.go - Wire
extListnerthroughengineand route start to the external listener when set
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rest/server.go | New WithExternalListener RunOption and net import |
| rest/internal/starter.go | Added StartHttpWithListner helper variant |
| rest/engine.go | Stored extListner in engine and branch start logic |
Comments suppressed due to low confidence (5)
rest/server.go:319
- The comment above
WithExternalListenerrefers toWithUnsignedCallbackand is misleading; update it to describe setting an external listener.
// WithUnsignedCallback returns a RunOption that with given unsigned callback set.
rest/server.go:320
- The parameter name
listneris misspelled; rename it tolistenerfor consistency.
func WithExternalListener(listner net.Listener) RunOption {
rest/internal/starter.go:20
- Function name
StartHttpWithListneris misspelled; consider renaming toStartHttpWithListener.
func StartHttpWithListner(l net.Listener, handler http.Handler, opts ...StartOption) error {
rest/engine.go:41
- Struct field
extListneris misspelled; rename toextListenerto match Go spelling conventions.
extListner net.Listener
rest/engine.go:337
- New branch for external listener mode should have corresponding unit/integration tests to cover the
extListner != nilpath.
if ng.extListner != nil {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
feat: reset engine can call rest.WithExternalListener to use external listener for start engine