Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit af0958c

Browse filesBrowse files
jeffwidmanjeffwidman
authored
Merge pull request dependabot#605 from dependabot/add-missing-octokit-package-to-package.json
`src/main.ts` includes the import: ```javascript import { RequestError } from '@octokit/request-error' ``` However, we weren't explicitly requiring this in `package.json`. It was implicitly coming in via `@actions/github` import, but best to be explicit about it. Discovered via: ```shell npm install -g npm-check npm-check ``` Which reported the following error: ``` @octokit/request-error 😟 PKG ERR! Not in the package.json. Found in: /src/main.test.ts, /src/main.ts ``` Note: There is a newer `v6` version of `@octokit/request-error` available. However, it threw a type error due a breaking change. So for now I only bumped to the `v5` version, and we can fix the upgrade later. It's a step in the right direction to at least make this import explicit.
2 parents 266c607 + acbb0b0 commit af0958c
Copy full SHA for af0958c

File tree

Expand file treeCollapse file tree

3 files changed

+225
-50
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+225
-50
lines changed

‎dist/index.js

Copy file name to clipboardExpand all lines: dist/index.js
+144-46Lines changed: 144 additions & 46 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package-lock.json

Copy file name to clipboardExpand all lines: package-lock.json
+80-4Lines changed: 80 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

Copy file name to clipboardExpand all lines: package.json
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
"dependencies": {
2525
"@actions/core": "^1.10.0",
2626
"@actions/github": "^5.1.1",
27+
"@octokit/request-error": "^5.1.1",
2728
"pluralize": "^8.0.0"
2829
},
2930
"devDependencies": {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.