add details about catching all exceptions#213
Merged
yasoob merged 2 commits intoyasoob:masteryasoob/intermediatePython:masterfrom Jul 20, 2020
Merged
add details about catching all exceptions#213yasoob merged 2 commits intoyasoob:masteryasoob/intermediatePython:masterfrom
yasoob merged 2 commits intoyasoob:masteryasoob/intermediatePython:masterfrom
Conversation
yasoob
requested changes
Jul 15, 2020
exceptions.rst
Outdated
| @@ -63,7 +63,15 @@ trapping ALL exceptions: | ||
| raise e | ||
|
|
||
| This can be helpful when you have no idea about the exceptions which may |
Owner
There was a problem hiding this comment.
can you update "which" to "that" while you are at it? :)
exceptions.rst
Outdated
|
|
||
| This can be helpful when you have no idea about the exceptions which may | ||
| be thrown by your program. | ||
| be thrown by your program. If you just looking to catch all execptions, |
Owner
There was a problem hiding this comment.
"If you just" -> "If you are just"
exceptions.rst
Outdated
| but don't actually care about what they are, you can even exclude the | ||
| ``Exception as e`` part. | ||
|
|
||
| Note: catching all exceptions may have unintended consequences because catching |
Owner
There was a problem hiding this comment.
"Note:" -> "Note::"
This will just make sure that it renders in a nice blue box on the website :)
Contributor
Author
|
Sorry it took a few days, but I updated the files with your requested changes! |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.