Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4e99b52

Browse filesBrowse files
committed
Use on/off for stop on fail banner display
1 parent 64d2a15 commit 4e99b52
Copy full SHA for 4e99b52

File tree

4 files changed

+4
-6
lines changed
Filter options

4 files changed

+4
-6
lines changed

‎src/xunit.runner.utility/Reporters/DefaultRunnerReporterMessageHandler.cs

Copy file name to clipboardExpand all lines: src/xunit.runner.utility/Reporters/DefaultRunnerReporterMessageHandler.cs
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,14 +230,13 @@ protected override bool Visit(ITestAssemblyExecutionStarting executionStarting)
230230
if (executionStarting.ExecutionOptions.GetDiagnosticMessagesOrDefault())
231231
{
232232
var threadCount = executionStarting.ExecutionOptions.GetMaxParallelThreadsOrDefault();
233-
var stopOnFail = executionStarting.ExecutionOptions.GetStopOnTestFailOrDefault().ToString().ToLowerInvariant();
234233

235234
Logger.LogImportantMessage(
236235
" Starting: {0} (parallel test collections = {1}, max threads = {2}, stop on fail = {3})",
237236
assemblyDisplayName,
238237
!executionStarting.ExecutionOptions.GetDisableParallelizationOrDefault() ? "on" : "off",
239238
threadCount < 0 ? "unlimited" : threadCount.ToString(CultureInfo.CurrentCulture),
240-
stopOnFail
239+
executionStarting.ExecutionOptions.GetStopOnTestFailOrDefault() ? "on" : "off"
241240
);
242241
}
243242
else

‎src/xunit.runner.utility/Reporters/DefaultRunnerReporterWithTypesMessageHandler.cs

Copy file name to clipboardExpand all lines: src/xunit.runner.utility/Reporters/DefaultRunnerReporterWithTypesMessageHandler.cs
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,14 +252,13 @@ protected virtual void HandleTestAssemblyExecutionStarting(MessageHandlerArgs<IT
252252
if (executionStarting.ExecutionOptions.GetDiagnosticMessagesOrDefault())
253253
{
254254
var threadCount = executionStarting.ExecutionOptions.GetMaxParallelThreadsOrDefault();
255-
var stopOnFail = executionStarting.ExecutionOptions.GetStopOnTestFailOrDefault().ToString().ToLowerInvariant();
256255

257256
Logger.LogImportantMessage(
258257
" Starting: {0} (parallel test collections = {1}, max threads = {2}, stop on fail = {3})",
259258
assemblyDisplayName,
260259
!executionStarting.ExecutionOptions.GetDisableParallelizationOrDefault() ? "on" : "off",
261260
threadCount < 0 ? "unlimited" : threadCount.ToString(CultureInfo.CurrentCulture),
262-
stopOnFail
261+
executionStarting.ExecutionOptions.GetStopOnTestFailOrDefault() ? "on" : "off"
263262
);
264263
}
265264
else

‎test/test.xunit.runner.utility/Extensibility/DefaultRunnerReporterMessageHandlerTests.cs

Copy file name to clipboardExpand all lines: test/test.xunit.runner.utility/Extensibility/DefaultRunnerReporterMessageHandlerTests.cs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ public class OnMessage_ITestAssemblyExecutionStarting
151151
{
152152
[Theory]
153153
[InlineData(false, "[Imp] => Starting: testAssembly")]
154-
[InlineData(true, "[Imp] => Starting: testAssembly (parallel test collections = on, max threads = 42, stop on fail = true)")]
154+
[InlineData(true, "[Imp] => Starting: testAssembly (parallel test collections = on, max threads = 42, stop on fail = on)")]
155155
public static void LogsMessage(bool diagnosticMessages, string expectedResult)
156156
{
157157
var message = Mocks.TestAssemblyExecutionStarting(diagnosticMessages: diagnosticMessages);

‎test/test.xunit.runner.utility/Extensibility/DefaultRunnerReporterWithTypesMessageHandlerTests.cs

Copy file name to clipboardExpand all lines: test/test.xunit.runner.utility/Extensibility/DefaultRunnerReporterWithTypesMessageHandlerTests.cs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ public class OnMessage_ITestAssemblyExecutionStarting
149149
{
150150
[Theory]
151151
[InlineData(false, "[Imp] => Starting: testAssembly")]
152-
[InlineData(true, "[Imp] => Starting: testAssembly (parallel test collections = on, max threads = 42, stop on fail = true)")]
152+
[InlineData(true, "[Imp] => Starting: testAssembly (parallel test collections = on, max threads = 42, stop on fail = on)")]
153153
public static void LogsMessage(bool diagnosticMessages, string expectedResult)
154154
{
155155
var message = Mocks.TestAssemblyExecutionStarting(diagnosticMessages: diagnosticMessages);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.