Fix build on CentOS 6 w/ xmlsec1-1.2.19-3#76
Merged
bgaifullin merged 1 commit intoxmlsec:masterxmlsec/python-xmlsec:masterfrom Jun 29, 2018
mintel:XMLSEC_CRYPTO-quotesmintel/python-xmlsec:XMLSEC_CRYPTO-quotesCopy head branch name to clipboard
Merged
Fix build on CentOS 6 w/ xmlsec1-1.2.19-3#76bgaifullin merged 1 commit intoxmlsec:masterxmlsec/python-xmlsec:masterfrom mintel:XMLSEC_CRYPTO-quotesmintel/python-xmlsec:XMLSEC_CRYPTO-quotesCopy head branch name to clipboard
bgaifullin merged 1 commit intoxmlsec:masterxmlsec/python-xmlsec:masterfrom
mintel:XMLSEC_CRYPTO-quotesmintel/python-xmlsec:XMLSEC_CRYPTO-quotesCopy head branch name to clipboard
Conversation
pkgconfig doesn't parse the XMLSEC_CRYPTO macro value correctly from xmlsec1-1.2.19-3 on CentOS 6 (the Changelog for [that RPM](https://centos.pkgs.org/6/centos-x86_64/xmlsec1-1.2.20-4.el6.x86_64.rpm.html) suggests there's been some bugs). ``` 2014-05-28 - Simo Sorce <simo@redhat.com> - 1.2.20-2 - Update pkg-config fix patch to apply w/o fuzz ... 2014-05-23 - Simo Sorce <simo@redhat.com> - 1.2.19-6 - Fix incomplete patch 2014-05-23 - Simo Sorce <simo@redhat.com> - 1.2.19-5 - Add patch to deal with different behavior of pkg-config in RHEL6 ``` This change fixes the build for xmlsec1-1.2.19-3.
bgaifullin
approved these changes
Jun 29, 2018
Collaborator
|
Thanks for PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkgconfig doesn't parse the XMLSEC_CRYPTO macro value correctly from xmlsec1-1.2.19-3 on CentOS 6: it comes already wrapped in quotes
"openssl", then xmlsec_setupinfo.py wraps it again""openssl"". So the gcc command ends up looking something like this:Which causes a syntax error when compiling main.c:
The Changelog for the xmlsec1 RPM suggests there's been some bugs with pkg-config that were fixed in later versions.
This change just checks if XMLSEC_CRYPTO is already wrapped in quotes.