Fix name collision with lxml's setupinfo.py#69
Merged
bgaifullin merged 1 commit intoxmlsec:masterxmlsec/python-xmlsec:masterfrom Aug 15, 2017
Merged
Fix name collision with lxml's setupinfo.py#69bgaifullin merged 1 commit intoxmlsec:masterxmlsec/python-xmlsec:masterfrom
bgaifullin merged 1 commit intoxmlsec:masterxmlsec/python-xmlsec:masterfrom
Conversation
When installing (ubuntu and arch, python 3.6.2 and python 3.5.x), lxml installation fails because it tries to import its own `setupinfo.py`, but gets python-xmlsec's `setupinfo.py`. Rename the module to make sure we don't get another name collision.
Collaborator
|
How does it happen. setupinfo is local file inside of package. why lxml tries to import file from xmlsec? |
Collaborator
|
Can you describe case step by step ? |
Author
|
Not quite sure, but I suspect it's because you've imported |
Collaborator
|
I got it, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing (ubuntu and arch, python 3.6.2 and python 3.5.x), lxml installation fails because it tries to import its own
setupinfo.py, but gets python-xmlsec'ssetupinfo.py. Rename the module to make sure we don't get another name collision.