Add public shareable chats #130
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Alexis Rico <sferadev@gmail.com>
Signed-off-by: Alexis Rico <sferadev@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds public shareable chats by introducing a new visibility property for chats and updating related middleware, database access, and UI components. Key changes include:
- Updating the middleware matcher to allow shareable chats.
- Adding a new "visibility" column, anonymous user role, and associated policy for public chats.
- Enhancing UI components to include visibility control and share functionality.
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/dbagent/src/middleware.ts | Updated matcher to include a public share route. |
| apps/dbagent/src/lib/monitoring/scheduler.ts | Fixed missing await for getAdminAccess. |
| apps/dbagent/src/lib/db/schema.ts | Added visibility column and anonymous user role with corresponding policy. |
| apps/dbagent/src/lib/db/db.ts | Introduced anonymous DB access and made admin access async. |
| apps/dbagent/src/lib/db/chats.ts | Adjusted saveChat function signature to support the new visibility property. |
| apps/dbagent/src/components/ui/side-nav.tsx | Added share functionality with new icons and toast notifications. |
| apps/dbagent/src/components/chat/visibility-selector.tsx | Introduced a VisibilitySelector component for managing chat visibility. |
| apps/dbagent/src/components/chat/header.tsx | Updated header to include VisibilitySelector and refactored navigation. |
| apps/dbagent/src/components/chat/chat.tsx | Updated Chat component to pass project & chat IDs and added ReadOnlyChat. |
| apps/dbagent/src/app/api/chat/route.ts | Modified PATCH handler to validate and persist title and visibility changes. |
| apps/dbagent/src/app/(main)/share/[chat]/page.tsx | Added a new page for displaying public, read-only chats. |
Files not reviewed (2)
- apps/dbagent/migrations/0008_public-chats.sql: Language not supported
- apps/dbagent/migrations/meta/_journal.json: Language not supported
| ); | ||
| }); | ||
|
|
||
| export function ReadOnlyChat({ messages }: { messages: Array<UIMessage> }) { |
There was a problem hiding this comment.
The unimplemented functions for setMessages and reload in ReadOnlyChat throw errors, which might lead to runtime issues if accidentally invoked. Consider providing safe no-op implementations or ensuring these callbacks are never triggered in read-only mode.
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.