forked from symfony/symfony
-
Notifications
You must be signed in to change notification settings - Fork 0
skip tests if required extension is not installed #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
xabbuh
commented
Sep 21, 2024
Q | A |
---|---|
Branch? | 7.2 |
Bug fix? | no |
New feature? | no |
Deprecations? | no |
Tickets | |
License | MIT |
Doc PR |
…tion introduced in Symfony 7.2 (wouterj) This PR was merged into the 6.4 branch. Discussion ---------- [Runtime] Adapt test to support the `--silent` option introduced in Symfony 7.2 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Prepare tests for symfony#53632 Commits ------- bc5ae53 [Runtime] Adapt test to support the --silent option introduced in Symfony 7.2
…mfony/notifier 7.x (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [Notifier] allow the Novu bridge to be used with symfony/notifier 7.x | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- 72d8178 allow the Novu bridge to be used with symfony/notifier 7.x
This PR was merged into the 6.4 branch. Discussion ---------- [Routing][Uid] [6.4] Mention RFC 9562 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Follow-up to symfony#58238 on 6.4 Commits ------- edf9916 [6.4][Routing][Uid] Mention RFC 9562
released v5.4.44
released v6.4.12
released v7.1.5
…tant (alexandre-daubois) This PR was merged into the 7.2 branch. Discussion ---------- [Routing] Add the `Requirement::UID_RFC9562` constant | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Following https://github.com/symfony/symfony/pull/58329/files#r1768217660 Commits ------- c1e1167 [Routing] Add the `Requirement::UID_RFC9562` constant
* 5.4: Bump Symfony version to 5.4.45 Update VERSION for 5.4.44 Update CONTRIBUTORS for 5.4.44 Update CHANGELOG for 5.4.44
* 6.4: Bump Symfony version to 6.4.13 Update VERSION for 6.4.12 Update CHANGELOG for 6.4.12 Bump Symfony version to 5.4.45 Update VERSION for 5.4.44 Update CONTRIBUTORS for 5.4.44 Update CHANGELOG for 5.4.44 allow the Novu bridge to be used with symfony/notifier 7.x [6.4][Routing][Uid] Mention RFC 9562 [Runtime] Adapt test to support the --silent option introduced in Symfony 7.2
* 7.1: Bump Symfony version to 7.1.6 Update VERSION for 7.1.5 Update CHANGELOG for 7.1.5 Bump Symfony version to 6.4.13 Update VERSION for 6.4.12 Update CHANGELOG for 6.4.12 Bump Symfony version to 5.4.45 Update VERSION for 5.4.44 Update CONTRIBUTORS for 5.4.44 Update CHANGELOG for 5.4.44 allow the Novu bridge to be used with symfony/notifier 7.x [6.4][Routing][Uid] Mention RFC 9562 [Runtime] Adapt test to support the --silent option introduced in Symfony 7.2
…output, including errors (wouterj) This PR was merged into the 7.2 branch. Discussion ---------- [Console] Add silent verbosity suppressing all output, including errors | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | yes | Issues | Fix symfony#52777 | License | MIT <details> <summary>Original PR description</summary> Alternative to symfony#53126 In Symfony 2.8, we decided to still show exceptions/errors when running a command with `--quiet` or `SHELL_VERBOSITY=-1` (symfony#15680). Since that time, we've introduced the ConsoleLogger and 12-factor app logic. In todays landscape, it's more common to run commands that only output computer-readable text (e.g. JSON), which is ingested and displayed by services like Datadog and Kibana. Our decision from 2.8 breaks this, as the JSON is interrupted by human-readable exception output that users can't disable. At the same time, this information is duplicated as errors are always logged (and thus shown as JSON). I think we should revert the 2.8 decision, rather than adding a new "extremely quiet" verbosity mode. As far as I'm aware, this is also more consistent with normal unix commands which also don't output anything when passing `--quiet`. I don't think this warrants as a BC break, as the errors are human readable and we don't promise BC on human readable console output (afaik, we don't promise BC on any console output, but I think we should be careful when changing e.g. the JSON logging). </details> This updated PR adds a new `--silent` verbosity mode that suppresses all output, including exceptions caught by the Application. I went back and forth between simply passing `NullOutput` to the command in silent mode or not ignoring everything written to silent mode in `Output`. In the end, I've decided for the last to avoid bug reports from people silently expecting a `ConsoleOutputInterface` in their commands (e.g. for sections) without properly guarding it. The new `isSilent()` methods can be used by commands to e.g. write important messages to the logger instead of command output when running in silent mode. Commits ------- 57fe0bd [Console] Add silent verbosity mode suppressing all output, including errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.