Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 18814a0

Browse filesBrowse files
wzssyqawzssyqa
committed
expandFMINIMUMNUM_FMAXIMUMNUM: Quiet is not needed for NaN vs NaN
New LangRef doesn't requires quieting for NaN vs NaN, aka the result may be sNaN for sNaN vs NaN. See: llvm#139228
1 parent 56aa935 commit 18814a0
Copy full SHA for 18814a0

File tree

Expand file treeCollapse file tree

1 file changed

+0
-5
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-5
lines changed

‎llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp

Copy file name to clipboardExpand all lines: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
-5Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8683,11 +8683,6 @@ SDValue TargetLowering::expandFMINIMUMNUM_FMAXIMUMNUM(SDNode *Node,
86838683

86848684
SDValue MinMax =
86858685
DAG.getSelectCC(DL, LHS, RHS, LHS, RHS, IsMax ? ISD::SETGT : ISD::SETLT);
8686-
// If MinMax is NaN, let's quiet it.
8687-
if (!Flags.hasNoNaNs() && !DAG.isKnownNeverNaN(LHS) &&
8688-
!DAG.isKnownNeverNaN(RHS)) {
8689-
MinMax = DAG.getNode(ISD::FCANONICALIZE, DL, VT, MinMax, Flags);
8690-
}
86918686

86928687
// Fixup signed zero behavior.
86938688
if (Options.NoSignedZerosFPMath || Flags.hasNoSignedZeros() ||

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.