Add a ping module#1623
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This would be useful |
|
Hey @tabell, First of all, thank you for the PR. I know it's been over a year since you've submitted it. I'm just taking the reins for this project and I'm doing my best to go through all of the old Issues and PRs. Do you still use WTF? Are you still interested in this PR? I tested it out, I have some questions/potential changes. I'm curious if you be willing to either 1) Work with me on getting the PR ready or if 2) I can take the PR from here and make the needed changes. If there isn't a response, I'll assume the latter. |
|
Hi,
Nice to hear there is a new maintainer of the project. I haven’t been using wtf lately but I can’t remember why I switched.
If the PR changes are minor I’d be happy to work with you, or if it’s easier for you to take over that’s fine too.
…On Sat, Jul 12, 2025, at 11:57, Ricardo N Feliciano wrote:
*FelicianoTech* left a comment (wtfutil/wtf#1623) <#1623 (comment)>
Hey @tabell <https://github.com/tabell>,
First of all, thank you for the PR. I know it's been over a year since you've submitted it. I'm just taking the reins for this project and I'm doing my best to go through all of the old Issues and PRs.
Do you still use WTF? Are you still interested in this PR? I tested it out, I have some questions/potential changes. I'm curious if you be willing to either 1) Work with me on getting the PR ready or if 2) I can take the PR from here and make the needed changes. If there isn't a response, I'll assume the latter.
—
Reply to this email directly, view it on GitHub <#1623 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJDA4NPKDZSFBE7OBMFECT3IFLAHAVCNFSM6AAAAACBMBKSY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANRVHE3DIOJUGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
So when I tested this PR, I put together an example WTF config. I wasn't sure the config you intended but I got something work. I was curious, how do you intend the config to look like for this module? The one I made is on my other laptop, which is currently 1,000 miles away. I'll see if I can recover what I did so we can compare. Lastly, considering the age of this PR, a rebase would help. Current code and it can then run the current test suite. 1 commit instead of the two currently would do. |
|
Since there's been no response, I went ahead with some changes of my own. I kept the majority of the code but made this changes to the PR:
This will be in WTF version v0.47.0. |
|
Docs need to be created for this new module. I made a tracking issue here: wtfutil/wtfdocs#192 |
This adds a very basic Ping module, for when you need to see if a service is online but you can't / don't want to use a third-party API like updown.io. Sends an ICMP (or UDP) echo request and displays whether a response was received.
Note: sending ICMP is a privileged operation on some versions of Linux, so you either need to grant the wtf binary CAP_NET_RAW capability or allow unprivileged users to send UDP pings https://github.com/prometheus-community/pro-bing#linux
I haven't tested on Windows or anything other than Linux.
This is my first wtf module so there's probably a bunch of stuff that could be better / cleaner. Happy to make changes / improvements based on suggestions.