domain name policy for WOLFSSL_APPLE_NATIVE_CERT_VALIDATION #8833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please Jenkins |
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Apple native certificate validation flow to leverage the WolfSSL domain name when available for SSL policy creation.
- Updated the function signature of DoAppleNativeCertValidation to include the ssl context.
- Added logic to extract and use the domain name to create a hostname-based SSL policy.
- Ensured proper memory management by releasing CF objects (hostname) after usage.
JacobBarthelmeh
requested changes
Jun 4, 2025
JacobBarthelmeh
previously approved these changes
Jun 4, 2025
SparkiDev
requested changes
Jun 5, 2025
|
Jenkins retest this please |
SparkiDev
approved these changes
Jun 5, 2025
8 tasks
kp-max-li
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Jun 6, 2025
Adopting a patch from wolfSSL/wolfssl#8833 on top of the current wolfssl version we are using. This patch ensures the domain check request is properly executed when using the Apple Native Certificate Validation routine.
kp-max-li
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Jun 6, 2025
Adopting a patch from wolfSSL/wolfssl#8833 on top of the current wolfssl version we are using. This patch ensures the domain check request is properly executed when using the Apple Native Certificate Validation routine.
kp-max-li
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Jun 9, 2025
Adopting a patch from wolfSSL/wolfssl#8833 on top of the current wolfssl version we are using. This patch ensures the domain check request is properly executed when using the Apple Native Certificate Validation routine.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use WOLFSSL domain name to create policy for WOLFSSL_APPLE_NATIVE_CERT_VALIDATION. When no domain name is available,
SecPolicyCreateSSL()uses NULL for the hostname parameter.Fixes zd#19957
Testing
Tested using
make checkand test provided in zendesk ticketChecklist