fix for https://github.com/wled/WLED/issues/4488 #4692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
this fix does NOT need porting to 0.15 as the bug this PR fixes was introduced in 0.16 |
Contributor
#ifndef WLED_DISABLE_2D
#define indexToVStrip(index, stripNr) ((index) | (int((stripNr)+1)<<16))
#else
#define indexToVStrip(index, stripNr) (index) // since stripNr will never be > 0
#endifWould have solved the issue as well. |
blazoncek
added a commit
that referenced
this pull request
Jul 4, 2025
- adds ability to configure variable number of buttons during runtime - fixes #4692
Merged
DedeHai
pushed a commit
that referenced
this pull request
Nov 27, 2025
* Variable button count (up to 32) - adds ability to configure variable number of buttons during runtime - fixes #4692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtual strip index is added even if strip is 1D. this change fixes FX using virtual strips not working when WLED_DISABLE_2D is used.
I recommend waiting to merge this until segment layering PR is merged.
Summary by CodeRabbit