Add ability to enter desired BSSID #4429
Conversation
- add event handling (debug) - fixes wled#2151
Liliputech
left a comment
There was a problem hiding this comment.
Good change overall with a nice move of initEthernet from wled.cpp to network.cpp.
Although most compilations (jobs) are successful, some of them have warnings (not breaking though)
Some of them seems to be related to your patch / code move.
|
That's just a harbinger of things to come. 😉 |
|
Please update the PR title to fully summarise the changes contained and extend the description as well please @blazoncek |
|
@netmindz the gist of this PR is in its title - ability to force BSSID selection. All other changes are just collateral damage from my fork. I do not intend to remove those as it is too much hassle otherwise. EDIT: The bugging part is a joke. |
|
@blazoncek I do not have a mesh system but to test this I had to use two esp32 nat router with the same SSID . One minor issue during the setup ( this issue has no impact on functionality ) is that the BSSID is populated with the SSIDs and one will be selected for you , once you hit save you will get a bad BSSID as you see in the pic below but as you have to enter that manually in any case then this is a minor thing but for sure will be confusing to others .
|
|
Thank you. |
@blazoncek could you be a bit more specific? The file is not modified by your PR. |
|
@softhack007 it is unrelated to this PR. Will include more info when ready. |
|
Are we ok to merge this? |
WLED::initEthernet()andWLED::findWiFi()tonetwork.cppWLED_WIFI_CONFIGUREDwith function call (and updated macro)WLED_ETHERNETOh, and BTW, there is a bug in
src/dependencies/network/Network.cpp.