Introduce printSetInputMaxlength to properly set an inputs maxlength … #4296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tagging you @softhack007 as you're aware of the context of the previous PR. |
Member
Hi, sorry HTML/JS is not my area. |
1 task
Contributor
|
If I was doing something like general method for modifying any attribute, I would have done it something like this: function upAttr(o,a,v)
{
d.Sf[o].setAttribute(a,v);
}settingsScript.printf_P(PSTR("upAttr('MD','maxlength',%d);upAttr('MG','maxlength',%d);upAttr('MS','maxlength',%d);"),
MQTT_MAX_TOPIC_LEN, MQTT_MAX_TOPIC_LEN, MQTT_MAX_SERVER_LEN);But particular case is only the issue of missing uppercase letter. Instead of So, according to W3C Schools, the solution with least change is: settingsScript.printf_P(PSTR("d.Sf.MD.maxLength=%d;d.Sf.MG.maxLength=%d;d.Sf.MS.maxLength=%d;"),
MQTT_MAX_TOPIC_LEN, MQTT_MAX_TOPIC_LEN, MQTT_MAX_SERVER_LEN); |
Contributor
Author
|
Damn, great catch. I agree with making the least amount of changes required. Will replace maxlength with maxLength like you proposed (tested it and it works). |
…xlength variable" This reverts commit 49fb16e.
Contributor
Author
|
I think we can merge this now. |
blazoncek
approved these changes
Nov 21, 2024
netmindz
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to !4295 by fixing MQTT related code that deals with the
MQTT_MAX_TOPIC_LENvariable.Previously, the
maxlengthattribute on the<input>fields insettings_sync.htmlwere set withinputElement.maxlength = <length>, however this did not seem to actually modify themaxlengthattribute as seen in the screenshot (also I couldn't type any more characters than the previous maxlength setting):As seen, modifying
element.maxlengthdoes actually modify the variable, but it does not modify themaxlengthattribute weirdly. Usingelement.setAttribute("maxlength", X)was the fix.In this PR I've modified the code to implement a function to use this JS line instead of the one previously used.