Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@askask
Copy link
Contributor

@askask askask commented Apr 9, 2024

This commit adds sending an ArtnetPollReply for the e131ProxyUniverse, which is currently not implemented.
It also checks that this universe doesn't overlap with the regular e131Universe, so no duplicate replies are sent.

@blazoncek
Copy link
Contributor

@mxklb @troyhacks @netmindz as you have more DMX experience can you verify/review this PR, please?

@netmindz
Copy link
Member

Is there an associated issue detailing what the issue is that this PR seeks to resolve?

It's hard to review a solution without a clear understanding of the intention

wled00/e131.cpp Show resolved Hide resolved
@troyhacks
Copy link
Contributor

I think it's a feature enhancement.

With some of the existing WLED code we can automatically detect Art-Net endpoints, and this appears to extend this to the Art-Net proxy system.

I haven't used this functionality but I don't think there's any risk in adding it.

Art-Net users at this level are few, I think. I'm one of them and I'm still kinda like ... whut? 😁

@askask
Copy link
Contributor Author

askask commented Apr 14, 2024

I think it's a feature enhancement.

With some of the existing WLED code we can automatically detect Art-Net endpoints, and this appears to extend this to the Art-Net proxy system.

Yes, that's correct. This is a nice feature to get a quick overview (for example in QLC) of the available Art-Net nodes in the network and it would be useful if it also worked for proxied DMX outputs.

@troyhacks
Copy link
Contributor

I'm good with adding this. Thanks, @askask

wled00/e131.cpp Show resolved Hide resolved
@mxklb
Copy link
Contributor

mxklb commented Apr 15, 2024

Looking good. I'm not using this artnet poll feature, so can't test it, but looks like an improvement for DMX proxy.

Save to merge

wled00/e131.cpp Show resolved Hide resolved
@blazoncek blazoncek merged commit 8110259 into wled:0_15 Apr 28, 2024
softhack007 pushed a commit to MoonModules/WLED-MM that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.